-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Add support for MCP protocol in core SDK #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d838741 to
6510bbb
Compare
0c49d4f to
fb2b3e9
Compare
6510bbb to
7332a6a
Compare
ccfc3f5 to
df16239
Compare
7332a6a to
b9a60a8
Compare
b9a60a8 to
d439c55
Compare
c6ae916 to
2ed09b3
Compare
d439c55 to
21fda7c
Compare
2ed09b3 to
42ffc59
Compare
twishabansal
reviewed
Jan 6, 2026
21fda7c to
1cc4528
Compare
42ffc59 to
ff077ca
Compare
1cc4528 to
028b426
Compare
ff077ca to
c9e4b5c
Compare
twishabansal
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR no. 5 - Adding support for MCP protocol in core SDK
PR no.4 - #132
PR no.3 - #131
PR no.2 - #128
PR no.1 - #126
Key Changes
Protocoltype and constantsWithProtocolto allow configuring the client version, including validation to prevent duplicate assignment.NewToolboxClientto instantiate the correct underlying transport (mcp20250618, mcp20250326, mcp20241105, toolbox) based on the configuration.protocolandtransportfields toToolboxClientto store state and configuration.WithProtocol(verifying configuration and error handling).GetSupportedMcpVersions.